It's a preference, but I lean toward "nay". You're already doing something kind of verbose, defining a record. Why not go the extra mile and use a meaningful name?

btw arguments are not keywords - keywords are a data type :f - unlike symbols they never resolve to another value, they just stand for themselves, usually used as keys in hash maps

I use f for a function args when there's no name that is more specific (when I'm writing a higher order function that isn't tied to any domain)

so yeah, with a record, either your code is generic enough that you shouldn't be using a record, or it's specific enough that a name more specific than f is called for

the @thing character is shorthand for (deref thing) ... in you example, you've var quoted the symbol with #' so you're referring to the var called my-atom in the some-ns namespace, which you then deref to get the atom stored in the var, and deref again to get the current state of the atom. Presumably you're doing that because the var is marked as ^:private ? Normally you would require some-ns and not var quote the symbol:

(require '[some-ns :as s])
@s/my-atom

Yes, the atom is private, but I need to access it in a test.

as an aside, a namespace scope atom is effectively a singleton, and there are a bunch of reasons not to use singletons

especially an atom - it's global mutable state

if you think it's clearer (-> some-ns/my-atom (var) (var-get) (deref)) is equivalent to @@#'some-ns/my-atom

I think the @@ is clearer when writing code, but using the functions makes it easier to understand what's happening. According to your answer and the answer above, var-get is the same as deref

deref on a var is the same as var-get, but var-get won't work on atom, future, delay, promise, etc.

Thanks

there is only one form which is using data - (:country data) so I would guess data should be a map with that key at least

i meant how map value get inserted to data

there is nothing passed to data in what you showed

my-finction-1 is returning a function of one argument and you have to call it providing the value for data

it captures arg1 arg2 and arg3 as a closure, so it could use those

I am calling using comp

(comp (my-function-1 args1 args2 args3) (my-function-2 args1)) 

will it by my-function-2 ?

(my-function-1 args1 args2 args3) returns a function f3 (my-function-2 args1) must return also a function f4 if you want to be able to compose (comp f3 f4) which also returns a function.

output of f4 will go as input of f3 right/

like ->

yes, but -> is a bit different

if you then call ((comp f3 f4) x) it is hte same as (f3 (f4 x))

so output of (f4 x) is passed as data in f3

data is ((my-function-2 args1) x) or whatever is the signature for x

(= ((comp f g) x)
   (-> x g f)) ;; true

will take a look and come back

@U01TLNH6ULD this happens because your input text occasionally doesn't have a newline in the end. re-seq returns you successive matches, and your regex's first part (before or) expects a space in the end. If there isn't a newline in the original text your code doesn't enter the space there causing the second part of the regex to match the last word.

Are you using float on purpose? Floats are problematic when testing for equality.

yep, when I do not do it , I see this

Expected (= 0.0 (cars-assemble/production-rate 0)) but got (not (= 0.0 0))

Maybe you could use with-precision?

in my code? or in the test ? Im not allowed to change the tests

I was thinking in the tests, since you would then limit the fractions in float.

@U0267SNCPEY what happens if you change the float call to double?

I was the person who ask

ahh, my bad

and when chancing it to a double I see this error message

Expected (= 1701.7 (cars-assemble/production-rate 10)) but got (not (= 1701.7 1701.7000000000003))

NP

(ns foo)

(defn success-rate
  "Gives back the succes rate at a certain speed"
  [speed]
  (cond
    (== speed 0) 0
    (< speed 5) 1
    (< speed 9) 0.9
    (== speed 9) 0.8
    (== speed 10) 0.77))

(defn production-rate
  "Returns the assembly line's production rate per hour,
   taking into account its success rate"
  [speed]
  (float (* (* 221 (success-rate speed) speed))))

(comment
  (= (float 1392.3) (production-rate 7)))

Do you have to return a float?

he, so does ( 1 2 3) not multiply 1 2 * 3

but must I do ( (1 2 ) 3)) `

when I do (* (* 221 speed) (success-rate speed))) it works

but when I do (* 221 speed) (success-rate speed)) it fails

very wierd

Yeah, just having (* 221.0 speed (success-rate speed)) seems to work

this has to do with Java types, Float != Double

if you use double, and round it to 1 decimal, it will work

Does something coerce the value into double?

Ah, the * result is double

So yes, the problem is the conversion double->float

Also, I think that performing multiplication twice (`( ( 221 (success-rate speed) speed)`) leads to bigger compound precision error

I have no idea

(= 0.0 0) is false but (== 0.0 0) is true, if you need floating point values, figure out a way to do your partitioning without equality checks

@U0267SNCPEY in (* (* 221 (success-rate speed) speed)) (notice the close paren you missed) the first * is identity except it throws for an arg that is not an instance of Number

also int is pretty much only useful for host interop where a method needs Integer, use long and double for numeric type coercions

@U051SS2EU how is the first one identity ? I do not understand what you mean with it

I thought the first one was again multiplycation

(* x) is x for all Numbers x

look at where the parens are

clj-refactor.el has move form, which I think does what you're looking for

https://github.com/clojure-emacs/clj-refactor.el/wiki/cljr-move-form

Fabulous. Thank you @U016JPB0Z27!