@matt.henley Hum... it's not always wrong, but in your case it is. I'd say you want to map each components to a namespace, think component diagram in UML.

Also, your tasklist is a poor's man data-structure and a remnant of you trying to do OOP. It doesn't need to be encapsulated behind an interface.

(def tasklists {})

You could spec it to help people understand its structure and work with it more effectively if you really wanted.

For your tasks, you could move them to be more like a state map with transitions. Like adding a status key: {:status #{:open :completed}}

So now you don't need a completed? isOpen? IsPrending? Etc. You can just call :status as a function

You can also now have a multi-spec over status

To specify all of your data invariant at any given state

And I would personally go all in with the state machine. And I'd create a transitions map which lists valid transition from a status to others like:

(def transitions
  {:open [:completed :pending]
   :completed []
   :pending [:completed]})

Now I would accept transition commands, and I would multi-spec them over the :status key

(defmulti t (fn[task new-state] [(:status task) new-state]))
(defmethod t [:open :close] [task new-state]
 (-> task
  (assoc :status new-state)
  (assoc :date-completed (. js/Date now))))
 (t {:status :open} :close)
;> {:status :close,
     :date-completed 1559792294514}

Finally, I'd move all that in a component which would be my only namespace for it all. Maybe I name it taskscheduler.cljs

And you'd think of some cool interface for that component.

Make these public

Internally, it would make new tasks by calling your create and adding them to the tasklists namespace global Var. It would check for the status by just checking the :status key on a task. It would transition status with the multi-method, throwing an exception if no valid transition from/to exists. It could return the valid transitions from the transitions map for a given task if you need to list them out in the UI for example.

I realize now maybe your tasks were more for a todo app 😋. I was definitely thinking scheduled jobs in my head.

The state machine might be overkill for that.

Then I'd just shove it all in say a todo.clj namespace. And I'd make it all simpler like:

(def lists (atom {}))
(defn new-list [name]
  ...)
(defn add-task [list-name item]
  ...)
(defn close-task [list-name task-idx]
  ...)
Etc.

What are options for browser automation from ClojureScript?

You could look at puppeteer

https://cambium.consulting/articles/2018/3/22/parallelizing-a-clojurescript-test-suite-part-1-the-guts-of-cljstest

I am trying to use websockets with sente. When I try to curl the endpoint i get this error message:

Client's Ring request doesn't have a client id. Does your server have the necessary keyword Ring middleware (`wrap-params` & `wrap-keyword-params`)?*

i guess curling isn't really the problem. i just realized in the gist i wasn't passing client-id query param

the actually problem that i was trying to reduce to the simplest case is that the clojurescript client is getting erroring out 403 when trying to establish the connection

403 Bad CSRF token. which tells me what is wrong, but i am not really sure how to resolve it. For this example i do not really care about csrf

@justin.williams.1181 lucky you 😄 i spent a lot on this few months ago 😄 and this is the answer https://github.com/ptaoussanis/sente/issues/339#issuecomment-478187728

ok, i set the csrf-token-fn to nil in the call to make-channel-socket! and that seems to have resolved my issue for the test case

yeah that's about it if you ever need a token just look at sente example it will give you a hint on how to do it. (render home.html on backend with csrf and then use that value for communication)

@lepistane yeah thanks that is what i figured out to work around. which example is that?

https://github.com/ptaoussanis/sente#example-projects official one

Hi! I'm trying to import classes from inside an external jar file but I'm having zero success - feel like I'm missing something obvious (it's my first foray into interop), would anyone be able to give me some pointers? 🙂

Hi all, a very beginner question, how does a function return something which manipulates a lazy map? a println works inside the func, but if I call it from outside it doesn't show anything

@comparalf I'm not sure if I'm reading that correctly, but if you call map inside the function you either need to realize the elements needed before you exit, or return the lazy-seq so something else can realize it

if you don't realize an element, and don't return the seq containing it, the containing sequence gets garbage collected without realizing it

user=> ,((fn [] (map println (range 1000)) nil))
nil

Uhm.. So, I think the question is now, how do you convert the map to something no-lazy? materialize it..

You want to use doall

or use run! or doseq instead of map if you weren't using the data

That said, it's not deep. So if you have lazy things of lazy things, you need to call doall on all of them.

Ya, also mapv, reduce and loop can be used instead for eager processing which return a useful value

And when you feel like you've mastered all that, transducers can also be used for eager processing. But that's more complicated so maybe don't start there.

Ok ok, I think I got the basic idea, I'll look for those functions, thanks to both

So I'm new-ish to clojure (at least at scale) and picking up someone else's codebase. If I had a bunch of "what's the prettiest way to write this?" questions which channel should I direct that at?

I consumed the style guide, but I'm trying for better than the minimum. ^_^

here or #clojure are fine

Thanks! ^_^ So which is preferred... (get-in data [0 :someKey]) (:someKey (first data)) or is there some clever difference between them?

I would not use get-in on a seq

So the second version is more data agnostic?

I'd use either (:some-key (first data)) or (-> data first :some-key) depending on what the surrounding code looked like.

(I agree with @hiredman that using get/`get-in` to navigate sequences is something I would not use)

If it helps this is a vector of... is map the right word in clojure for {:a 2}?. And a vector is still officially a seq right?

Honestly the data in here looks like json with {}/[] nestings

no

vectors are not seqs

List => seq and vector as peers then?

>.< Sorry, clearly got a lot left to learn

a seq is like an iterator

when you get an iterator over a collection, that iterator is not the collection

so you can get a seq from a vector, but a vector is not a seq

So if in my earlier example I preface with...

(def data [{someKey 12} {someKey 22}])

assuming I want 12

I think the issue is that using get/get-in restricts your function to only working with vectors instead of sequences in general

Making the other way more data agnostic?

yeah, it could come back to bite you later on if you pass eg. the result of a map or filter to it

That makes sense. If the pathing down starts to get pretty long is there a better option, or should I vec=>get-in to get the same behavior?

the -> threading macro is a pretty readable option for that

you could also look into destructuring the value directly

Ok, I can see how to do it that way. I'm coming from js/ramda https://ramdajs.com/0.19.1/docs/#path and I suppose that warped my perception here a bit. Still learning to think more clojure-y

I don't think there's anything wrong with using get-in here if you know that all the data structures you're going to be traversing are associative, and both maps and vectors are.

Ohhh, new concept for me here, what exactly does associative mean? (linked article would be fine if more convenient)

In fact, personally I would prefer get-in in that case.

Let me see if I can dig up some reference material for you.

🙇 thank you!

Not finding anything great, unfortunately. I'll tuck my own explanation in this thread.

Hoping out of the thread, get or get-in are introducing a requirement of associative, while arguably being a bit simpler/more readable depending on taste?

Sounds right to me.

The thing I like about get-in in this case relative to, say, -> is that it's easier to scan (makes the intent more explicit), particularly as … gets long. For instance, if I see (get-in x …) even before looking at … I already know that all we're doing is accessing data within x. By contrast, if I see (-> x …) I need to read each item in … to understand whether we're accessing data, transforming data, triggering side effects, or some combination of all three.

This is an instance of the more general principle of using the smallest / most limited tool for the job.

But as you say, it's definitely a question of taste. 🙂

get-in is great when someone else hands you the path

@alexmiller Yeah, that's more the pattern I'm used to in Ramda too where we're handing around paths near as much as data (ok, like 20% as much, but still) That said the much greater diversity of data representations in clojure makes get-in significantly less safe than path is in JS

A point I didn't know before this channel!

🙇 thank you!

@suni_masuno Something else to be aware of

user=> (get-in [{:some-key 12} {:some-key 22}] [2 :some-key])
nil
user=> (-> [{:some-key 12} {:some-key 22}] (nth 2) :some-key)
Execution error (IndexOutOfBoundsException) at user/eval37656 (REPL:4).
null
user=> 

user=> (get-in (list {:some-key 12} {:some-key 22}) [2 :some-key])
nil
user=> (get-in (list {:some-key 12} {:some-key 22}) [1 :some-key])
nil
user=> (-> (list {:some-key 12} {:some-key 22}) (nth 2) :some-key)
Execution error (IndexOutOfBoundsException) at user/eval37662 (REPL:7).
null
user=> (-> (list {:some-key 12} {:some-key 22}) (nth 1) :some-key)
22
user=> 

Not sure if this is the correct channel. regarding a clojurescript question: I started a new project with figwheel and it was running correctly my reload function, css changes make my project reload as well. But when i started with figwheel-main tools and lein trampoline i just loose theses features. Probably i may didnt understand my config with my profiles settings. Someone here can help me?

@papachan do you have the figwheel-main.edn file?

sure

{:target-dir "resources"
 :watch-dirs ["src"]
 :open-url ""}

I did the same thing, migrate from to figwheel to figwheel-main, I remember to change my aliases in project.clj

:aliases {"fig"       ["run" "-m" "figwheel.main"]
            "fig:build" ["run" "-m" "figwheel.main" "-b" "dev" "-r"]
            "fig:min"   ["run" "-m" "figwheel.main" "-O" "advanced" "-bo" "dev"]
            "fig:test"  ["run" "-m" "figwheel.main" "-co" "test.cljs.edn" "-m" condo.test-runner]

I've just tested de fig:build.. but it works so I think at least, it'll run

And I added [com.bhauman/figwheel-main "0.1.9"] for dependencies in dev profile

here there are my aliases settings:

:aliases { "fig" ["trampoline" "run" "-m" "figwheel.main"]
             "fig:dev" ["trampoline" "run" "-m" "figwheel.main" "-b" "dev" "-r"]}

I had not never seen trampoline, you could try give a shot without it, using the same parameters that fig:build

OK

hmmm same behaviour

Uhm, if the problem is with the css files, in the project.clj

:resource-paths ["resources"]

with figwheel i had this, i suppose its not valid anymore when i move to figwheel-main

:figwheel {
             :css-dirs ["resources/public/css"] ;; watch and update CSS

https://figwheel.org/tutorial.html#live-reload-css

Oh i can add this to dev.cljs.edn file

^{:watch-dirs ["test/cljs" "src/cljs" "src/cljc"]
  :css-dirs ["resources/public/css"]
  :auto-testing true
  :log-level :error}

I hope so.. haahahah

That's my dev.cljs.edn

yeah it worked

Perfect

my last question is how i can use again this reload function: :figwheel {:on-jsload "clojurescript-app.core/on-js-reload"

wouldn't that just be adding an :on-jsload key to the dev.cljs.edn?

maybe it's too much to hope it would be that simple

{:watch-dirs ...,
   :css-dirs ...,
   :auto-testing ...,
   :on-jsload ...}
   ^^^^^^^^^^

should be one of ...

it didnt accept it