As of bb 1.13.222, https://github.com/seancorfield/rephrase (`main` branch, 1.0.6 will happen once Jolt 0.8.8 is released) is now fully compatible with Babashka!
The new Maven-y stuff in bb: that sets a useragent for downloads, right? I just saw Toby asking if Grenadine does (it does not, yet).
There is a discussion about it here: https://clojurians.slack.com/archives/CLX41ASCS/p1789050502490279
if Grenadine was using tools.deps, it would get the default library behavior of setting the User-Agent to tools.deps. but of course, it uses AI garbage copy instead, oh well.
I thought they changed it to vendor-in & patch tools.deps as part of the build?
yes, it applies a patch that replaces tools.deps with the old AI copy
so it deletes all of tools.deps, and adds all of the prior code
is this better? no, it is even dumber and more fragile. but it does acknowledge some provenance
Ah, I didn't realize their "patch" for so extensive 😞 That is, indeed, very dumb.
Bb isn't using grenadine
We know. I linked to the relevant bb code above.
Another project switched to a completely bb-driven build.clj: https://github.com/seancorfield/next-jdbc
So, that's HoneySQL, rephrase, and now next-jdbc!
The next piece of work will be to update deps-new so that :build :bb produces similar build.clj / bb.edn combinations!
> The next piece of work will be to update deps-new so that :build :bb produces similar build.clj / bb.edn combinations!
Nice!
When you incorporated tools.build, were you aware of https://ask.clojure.org/index.php/15208/tools-build-copy-task-does-not-respect-non-replaced-exts (which has not been fixed yet)? Specifically https://github.com/clojure/tools.build/blob/master/src/main/clojure/clojure/tools/build/tasks/copy.clj#L69 uses the default var instead of the parameter passed in.
The reason I ask is that deps-new patches tools.build to fix that: https://github.com/seancorfield/deps-new/blob/develop/src/org/corfield/new.clj#L97-L99
If I switch things over to bb-powered build.clj, will that patching code work? Or would you consider fixing that bug in the vendored tools.build code?
I think alter-var-root fixes will work since bb exposes the tools.build code as is as much as possible. Whether I should included non-upstream patches.. not sure!
I think it might be better to just follow upstream as much as possible
Reasonable. I've nudged Alex about it in #C02B5GHQWP4 since I opened the Ask a month and a half ago and there's no Jira yet.
I did subscribe to tools.deps/build releases on github, not sure if it will notify me of new "tag"s rather than Github Releases as well, but notify me whenever it comes out
Presumably, you'll just manually vendor in a new version of tools.build whenever it ... hah, jinx 🙂 Okay, that answers that question.
yep