Clojurians Log v2

I'm currently working on http-client, would something like (make-proxy-selector [[<pred> <proxy-config>] [<pred> <proxy-config>]) be considered idiomatic? For pred, I'd write some combinator functions like this:

(defn proxy-scheme [scheme proxy-config]
  [(fn [^URI uri] (= (.getScheme uri) scheme)) (->Proxy proxy-config)])
(defn exclude-urls [excluded-urls]
  [(fn [^URI uri] (some (fn [excluded-url] (str/ends-with? (.getHost uri) excluded-url)))) java.net.Proxy/NO_PROXY])

don't know, I'd have to look into this. how do other libs do this like hato, clj-http etc?

I'll have a look, thanks for the pointers!

I've opened a https://github.com/babashka/http-client/pull/81 containing my first stab at an implementation. It also contains some default proxy functionality that I haven't tested yet, I can rip that out and implement that separately.

(feel free to unleash devastating feedback, this has been quite fun in itself).

Can you lay out the interop that is necessary to do what you want? Then we should enable that in babashka + also adding idiomatic Clojure support to babashka.http-client

I think it would just be having the java.net.Proxy class available, then I would do something like

(defn get-default-proxy []
  ...
  (proxy [ProxySelector] []
    (select [uri]
      (cond
        (= no-proxy :all) Proxy/NO_PROXY
        (contains no-proxy-list (str uri)) Proxy/NO_PROXY
        (= (.getScheme uri) "https") (Proxy. Proxy$Type/HTTP <proxy-constructed-from "https_proxy")
        (= (.getScheme uri) "http") (Proxy. ...))))))

so you also need ProxySelector then right

That's already in

then it makes even more sense to just add http://java.net.Proxy

I'll look into building a person bb that has the classes, I remember seeing some documentation for that.

the class can be added to src/babashka/impl/classes.clj but we need some interop tests around this in babashka.interop-test to be tested with the native. just writing a Github issue is ok too

probably you will have to add Proxy$Type separately too

Huh, I'm tryng to build babashka from source, but the uberjar script gets to the reflection step (`lein with-profiles …,+reflection do run` ) and just hangs. Strange.

did you clone the submodules too? this is a common mistake people forget

yep, forgot it before, did it correctly, but it still hangs. Strange.

are you running with a graalvm jvm?

Huh, now it seems to work. Great.

Thanks for the help nonetheless!

ok :)

There's a https://github.com/babashka/babashka/pull/1970, I hope this is somewhat useful.

looks good!

Awesome! I'll write some code for http-client later this week.

great, thanks

Hey, is there still something missing in the http-client PR for more complicated proxy routing?

I hope to look at this soon again. currently focusing on different parts of bb libs :) Also, not high priority since we can do it using Java interop already, right?

No problem! Yeah, I think so re. Java interop, but I also have the "default proxy" functionality in the pipe somewhere.

👍 let me make a note to look at this before I publish a new bb

currently I'm knee-deep in bb.cli new features

oh no, even includes my spelling mistakes 😛

I thought I fixed those? ;)

Ah, it's only in this message. Thanks for the spelling correction.

$ bb -e 'java.util.concurrent.locks.ReentrantLock'
java.util.concurrent.locks.ReentrantLock

still part of bb

I must be doing something wrong then. Thanks!

check the version of your bb

babashka v1.12.199

that's old

that's what homebrew on linux got me...

maybe update your homebrew repo

ReentrantLock was added in .200

ok thx I really must have messed up something with homebrew.

my bad I am an idiot... I have mise messing things up... bb must be installed twice I updating the brew won't fix my issue.

no problem

Thanks again.

its fixed!

Let me see if I understand the problem... the bencode from nREPL is interleaved?

oh I see

I think the bencode writer should be serialized using locking or so

such that they can't be interleaved

let me push a fix so you can use the development version

Amazing, thanks 🙂. I'll check it as soon as you push the fix (hopefully I can also reproduce the problem, it's hard to reliably reproduce it...)

pushed fix. wait for 10 mins and then install the dev build with:

bash <(curl )  --dev-build --dir /tmp

Just a heads up... I am still looking at this error. Because the interleave happens with async code, it's hard to reliably reproduce... and suddenly, I can't anymore facepalm. So I'm starting to implement a part of the code that's completely parallel, to check if I can reproduce the error again, and as soon as I can I'll test with this dev build 🙂

I have a test which reproduces this

And it works, thanks! The error I was experiencing on my side is also fixed 👍