How many people here are using specter in bb? The reason I'm asking is: I fixed a bug today in SCI and I discovered that some of specter's tests (at least one) passed because in some cases it relied on this bug facepalm
This was the failing case in SCI:
(def x 1)
(let [x 2
x #'x]
x) ;;=> 2
So the local name would override the var resolution and #'x would just resolve to the local x in the case of a var literal.
Now it becomes apparent why this special way of macroexpanding is important in specter:
https://github.com/redplanetlabs/specter/blob/9a615ff22c7b6541284fea25de08d6c73e2cd222/src/clj/com/rpl/specter.cljc#L282
Perhaps I can make a version of riddley that works with bb though.ah luckily it's just this test that doesn't work:
(deftest nested-inline-caching-test
(is (= [[1]]
(let [a :b]
(select
(s/view
(fn [v]
(select [(s/keypath v) (s/keypath a)]
{:a {:b 1}})))
:a)))))I think I found a good compromise for specter in bb: avoid some macro-magical optimizations altogether
😌
oh my thats interesting 🪄, I do like some specter in BB personally, so I appreciate the arcano-maintenance
I think specter will still work fine as a git dep in the newly forthcoming bb
ah wait, no, specter has no deps.edn darnit ;)
well maybe you can poke Nathan for a new release. the change I made works with old and future bb
i'll forward this thread over to #specter 👍
nmarz says they just cut a new release
Somehow I missed this babashka "Interactive Shell Scripting" youtube video by @pez! https://www.youtube.com/watch?v=fa5ig2cIWnU