#!/usr/bin/env bb
(require '[babashka.fs :as :fs]
         '[babashka.process :refer [shell]])

(def make "/usr/bin/make")

(defn find-root
  ([]   (find-root (fs/cwd)))
  ([wd] (cond
          (fs/exists? (fs/path wd "Makefile")) {:dir wd}
          (fs/same-file? (fs/home) wd)         :not-found
          (fs/exists? (fs/path wd ".git"))     :not-found
          :else                                (find-root (fs/parent wd)))))

(defn run-make [wd & args]
  (if (= :not-found wd)
    (throw (Exception. "Makefile not found"))
    (apply shell wd make args)))

(when (= *file* (System/getProperty "babashka.file"))
  (apply run-make (find-root) *command-line-args*))

Neat idea. A couple suggestions: • Replace the recursive find-root call with a call to recur. • Replace (throw (Exception. "Makefile not found")) with (throw (ex-info "Makefile not found" {:babashka/exit 1})), which will make Babashka print out the error message cleaner than the exception stack trace stuff.

I think babashka can exec? That might be better than subprocess

There is a PR for a similar function as find-root here: https://github.com/babashka/fs/issues/112 Something here tells me that I was right about not including it yet, since it seems the requirements of the above variant are slightly different

thank you all for the feedback, this is very valuable to me 😃

> I think babashka can exec? That might be better than subprocess AFAICT it doesn’t support :dir, though. I could be missing something

yeah, that's a good point

I’ve looked into the source, but a “fix” for that is beyond me 😅

I don't think it's fixable unless graalvm supports it.

yeah for my purposes, the extra shell doesn’t matter. the time the actual make invocation takes dominates the script 🙃

for future reference, https://gist.github.com/srenatus/bbea51ca88ca93da7fa4414c4f749c1a

changed it now to throw an exception when the make call itself errors:

(-> (apply shell (assoc wd :continue true) make args)
      :exit
      System/exit)))

please use a thread for addressing one topic

did you set the correct JVM properties for accessing the firewall?

https://docs.oracle.com/en%2Fjava%2Fjavase%2F11%2Fdocs%2Fapi%2F%2F/java.base/java/net/doc-files/net-properties.html

Woops, sorry I thought messaging below myself would merge the messges into a thread (like MS teams).

I will try the jvm settings

also maybe re-download the previous version of bb manually via github releases into another directory and try it as well. I have no idea why things should have changed, but perhaps you can find the exact version when it changed

Now, I am not quite familiar I am doing this right. Is this the way?

{:paths ["src"] :deps {tick/tick {:mvn/version "RELEASE"} org.babashka/http-client {:mvn/version "0.3.11"}} :jvm-opts ["-Dhttp.proxyHost=127.0.0.1" "-Dhttp.proxyPort=3128" "-Dhttps.proxyHost=127.0.0.1" "-Dhttps.proxyPort=3128" "-Dhttps.nonProxyHosts=localhost"]}

bb.edn doesn't respect jvm-opts currently, also deps.edn doesn't support them at the top level. you can set them either on the command line or programmatically

bb -Dhttp.proxyPort=.... 

or (System/setProperty "http.proxyPort" ...)

gotta go now, will check back tomorrow

That worked. Thank you!