You should probably wait for the process to end?

aa, might be, did do deref though on the process object, but have to check again

interesting that same happens with say

(clojure.java.shell/sh "sleep" "1")

(clojure.java.shell/sh "sleep" "0")

maybe you can make a small repro so I can have a look?

I can try 🙂

betting that there is something else in my project setup that causes this...

0% cat bb.edn
{:tasks
 {shutdown-hook {:requires ([clojure.java.shell :refer [sh]])
                 :task (do
                         (.addShutdownHook (Runtime/getRuntime) (Thread. (fn []
                                                                           (println "hook running")
                                                                           (sh "sleep" "10")
                                                                           (println "hook done"))))
                         (shell "clojure"))}}}
[email protected] ~/work/babashka-stuff
0% cat deps.edn
{:deps {nrepl/nrepl                {:mvn/version "1.0.0"}
        cider/cider-nrepl          {:mvn/version "0.28.6"}
        com.bhauman/rebel-readline {:mvn/version "0.1.4"}}
 :main-opts ["-m" "nrepl.cmdline"
             "--middleware" "[cider.nrepl/cider-middleware]"
             "--interactive"
             "--repl-fn" "rebel-readline.main/-main"]}
[email protected] ~/work/babashka-stuff
0% bb run shutdown-hook
Clojure 1.11.1
user=> ^D
hook running
^Chook done
[email protected] ~/work/babashka-stuff
0% echo $?
0
[email protected] ~/work/babashka-stuff
0% bb run shutdown-hook
Clojure 1.11.1
user=> ^Chook running
Error while executing task: shutdown-hook
^Chook done
[email protected] ~/work/babashka-stuff
0% echo $?
130
[email protected] ~/work/babashka-stuff
0% bb run shutdown-hook
Clojure 1.11.1
user=> ^D
hook running
hook done
[email protected] ~/work/babashka-stuff
0% echo $?
0
[email protected] ~/work/babashka-stuff
0% bb run shutdown-hook
Clojure 1.11.1
user=> ^Chook running
Error while executing task: shutdown-hook
hook done
[email protected] ~/work/babashka-stuff
0% echo $?
130

but this not big deal, I bet there are bigger fishes elsewhere 😄

The fix:

{:tasks
 {shutdown-hook {:requires ([clojure.java.shell :refer [sh]])
                 :task (do
                         (.addShutdownHook
                          (Runtime/getRuntime) (Thread. (fn []
                                                          (println "hook running")
                                                          (sh "sleep" "10")
                                                          (println "hook done"))))
                         (shell {:continue true} "clojure"))}}}

So use {:continue true} to not throw when the exit code is zero

aa, nice!

Seems to work great, thank you! 🙂

command line, the great bridge pipe

You can create a bb.edn file to make it a project

You can also just start the nREPL server in a terminal and then connect from emacs

(https://book.babashka.org/#_nrepl)

Yes, and this is what I have been doing - but I’m trying to avoid littering my filesystem with unnecessary EDNs. I’d like it to be just like when I use a shell script with no additional files.

When I start the repl in the terminal - that works, but it’s not integrated into emacs.

It’s more of a cider / emacs question really I think. But since it’s babashka, I started here.

Use cider-connect to the nREPL server you start in the terminal. Don't use jack-in if you don't have a project, I guess

I'm talking about an nREPL server. not about a console REPL where you type expressions in your terminal.

This is documented in the link I pasted above.

Yes - I can do that. I’m just trying to do it in emacs.

Those docs work, I’m just trying to figure out how to do it in emacs using the elisp cider functions.

right

But I can create a new function specifically for this - there is just a lot of functionality already there and I thought maybe I was missing something.

Right now, it appears that cider doesn’t really handle “no project detected” in a flexible way. It forces the default jack-in command at that point.

ah - maybe @U02CV2P4J6S knows more about this

kk - thanks for the quick chat, will dig further.

https://github.com/clojure-emacs/cider/pull/3286 providing jack in cmd doesn't work right now but I made a pull request that probably soon is merged. With this you can either use a param like you want to, or use a dir locals. For the moment you could checkout the branch or you could make a bb.edn with an empty map in every dir you want to start bb nrepl as a workaround @U0250GGJGAE

another workaround:

;; the equivalent of the proposed change
(advice-add
 'cider--update-jack-in-cmd
 :before-until
 (defun cider-dont-update-jack-in-cmd-when-given (params)
   (when (plist-get params :jack-in-cmd) params)))

;; now a nbb jack in command becomes:
(cider-jack-in '(:jack-in-cmd "nbb nrepl-server"))

I have this in my config (stolen from corgi) for a quick jack-in to a babashka file https://github.com/dakra/dmacs/blob/632864dacd60d61c948a657d703eddcb761cd9f7/init.org?plain=1#L5745-L5765

;; jack-in for babashka from corgi
;; 
(defun cider-jack-in-babashka (&optional project-dir)
  "Start a utility CIDER REPL backed by Babashka, not related to a specific project."
  (interactive)
  (let ((project-dir (or project-dir (project-root (project-current t)))))
    (nrepl-start-server-process
     project-dir
     "bb --nrepl-server 0"
     (lambda (server-buffer)
       (cider-nrepl-connect
        (list :repl-buffer server-buffer
              :repl-type 'clj
              :host (plist-get nrepl-endpoint :host)
              :port (plist-get nrepl-endpoint :port)
              :project-dir project-dir
              :session-name "babashka"
              :repl-init-function (lambda ()
                                    (setq-local cljr-suppress-no-project-warning t
                                                cljr-suppress-middleware-warnings t)
                                    (rename-buffer "*babashka-repl*"))))))))

Nice! Perhaps something for the babashka wiki

https://github.com/babashka/babashka/wiki/GNU-Emacs Apparently I made this entry 2021 already 😄

I guess that was before there was "official" babashka support in cider

oh lol

well, it's only 2 years until we have this conversation again then :)

😄

Nice! Thanks @U02CV2P4J6S, @UFAP0C8KU - exactly what I’m looking for.

(If you are living on the latest master cider branch, e.g. with the straight package manager, there is also the yet-unreleased https://github.com/clojure-emacs/cider/blob/master/doc/modules/ROOT/pages/basics/up_and_running.adoc#Universal-jack-in command you might want consider. It uses emacs numerical arguments (M-1 M-x cider-jack-in-universal, M-2 ... etc) to quickly launch one of clojure cli, lein, bb or nbb nREPLs outside of a project)