Calling it like (#'last-modified whatever) doesn't work.

I’d probably use the .lastModified method for File via interop than trying to get the private fn to work if I’m just comparing times.

or https://docs.oracle.com/javase/7/docs/api/java/nio/file/Files.html#getLastModifiedTime(java.nio.file.Path,%20java.nio.file.LinkOption...)

Use modified-since

@U04V15CAJ that would not support comparing with a timestamp right? it needs another file? i think the use case is to compare with a timestamp

@UPD88PGNT also just found out https://github.com/babashka/fs/blob/master/API.md#babashka.fs/last-modified-time is already there.

Yep and there are also functions to convert that result to a long etc

Right, modified-since is closest to what I want since it can take a directory and walk it recursively to find the latest modified time. I don't want to compare against another file though, I want to compare it to another time. last-modified-time only works on one file so I'd have to recurse myself. https://github.com/babashka/fs/blob/8a8bfa618be6f0c1b21be0daafd1887e2a4f5c44/src/babashka/fs.cljc#L873-L875

yes

Oh, ok.

I copied last-modified and last-modified-1 into my code.

maybe we could change modified-since to also accept a time (or times) to compare against

I don't think there is a need to copy last-modified since you can use fs/last-modified-time

+ fs/file-time->millis

but feel free to do so :)

last-modified-time only works against one file, right? I was trying to reuse the code that finds the latest of many files in a folder.

you can do that like this:

$ bb -e '(map (comp fs/file-time->millis fs/last-modified-time) (fs/glob "." "**"))'
(1674917980174 1674917980162 1674917980162 1674917980172 1674917980171 1674917980171 1674917980172

$ bb -e '(apply max 0 (map (comp fs/file-time->millis fs/last-modified-time) (fs/glob "." "**")))'
1674917980175

Ok, yea. That's a good idea, thanks!

(fs/glob "." "**") gives:

java.nio.file.NoSuchFileException: c:\Users\me\containers\homer\out\bin\arch
 at sun.nio.fs.WindowsFileSystemProvider.isHidden (WindowsFileSystemProvider.java:471)

it's from running docker build -o out .

Can you give a fuller reproduction of what you're doing?

as in, are you executing this from the command line or how?

I just reproduced it by making a symlink to a file and then deleting the file. e.g. I made the file target , made a symlink (in cmd.exe mklink link target), deleted target, and then in my bb nrepl (fs/glob "." "**") gives

java.nio.file.NoSuchFileException: c:\Users\me\test\link
 at sun.nio.fs.WindowsFileSystemProvider.isHidden (WindowsFileSystemProvider.java:471)

ah

try (glob "." "**" {:follow-links false})

(fs/glob "." "**" {:follow-links false})

Try :hidden true

I think you can reproduce this with (fs/hidden? the-dead-link)

The smaller your repro the better

Yea, java.nio.file.NoSuchFileException: test\link (fs/hidden? "test/link")

Let me try to repro that locally

lrwxr-xr-x   1 borkdude  wheel     1 Jan 28 20:07 a -> b
drwxrwxrwt  51 root      wheel  1632 Jan 28 20:06 ..
borkdude@m1 /tmp/test-link $ bb -e '(fs/hidden? "a")'
false

All fs is calling here is https://docs.oracle.com/javase/7/docs/api/java/nio/file/Files.html#isHidden(java.nio.file.Path)

Can you try to repro this using (java.nio.file.Files/isHidden (fs/path "a"))

Can you try :hidden true in glob

that skips the hidden? check

(Files/isHidden (.toPath (fs/file "test/link")))

java.nio.file.NoSuchFileException: test\link
 at sun.nio.fs.WindowsFileSystemProvider.isHidden (WindowsFileSystemProvider.java:471)

(fs/glob "test" "**" {:hidden true}) is fine

[#object[sun.nio.fs.WindowsPath 0x1803c3ff "test\\link"]]

ok