Fork me on GitHub
#babashka
<
2022-04-15
>
Erkan10:04:52

Heyo @borkdude why did you change bb Dockerfile to linux/amd64 -> linux/arm64 ?

Erkan11:04:48

It also doubled in size? 😮

borkdude11:04:37

When did this happen?

borkdude11:04:48

Might be a change that @rahul080327 did in his PR last night?

lispyclouds11:04:03

interesting, having a look if i caused it, what exactly is the change youre seeing @UFUKJ3QG7? the arch is different?

lispyclouds11:04:27

ah yes theres no amd64, checking now

Erkan11:04:06

Dockerhub it says it was 1h ago

borkdude11:04:02

@rahul080327 You aren't overwriting the latest ones with versions from master, right....?

borkdude11:04:15

@UFUKJ3QG7 Can you specify which exact version you were using

lispyclouds11:04:20

yeah the latest will be overwritten even push to master. theres a bug which doesnt make the amd64 archs, its only arm

borkdude11:04:59

that's not how it should be, latest = latest stable!

borkdude11:04:08

I've explained this several times in the past :(

borkdude11:04:48

I should have reviewed the PR better, sorry

lispyclouds11:04:22

ah, but wasnt that how the shell script was working? sorry fixing right now

borkdude11:04:53

yes, that's how the shell script has always worked and last time there was a refactoring to this with the buildx stuff this mistake was also made and corrected later

borkdude11:04:25

we should revert the latest images to the latest stable asap

borkdude11:04:09

maybe by rebuilding the 0.8.0 release in circleci?

lispyclouds11:04:23

should i do a revert of my commit, that should get it back to it, til i fix the bug?

borkdude11:04:49

ok, let's do that, but that still won't fix latest stable

lispyclouds11:04:11

I'll try a rebuild of from circle now

borkdude11:04:16

since latest should be only pushed on non-SNAPSHOT releases

lispyclouds11:04:34

rerunning the last 0.8.0 one now

🙏 1
borkdude11:04:00

let's also revert the commit and be more careful next time

borkdude11:04:44

pushed reverted commit

lispyclouds11:04:46

yeah its quite a complex thing and feared i missed something 😕

borkdude11:04:07

quite understandable, but I don't want to break any daily usage of babashka :)

borkdude11:04:23

-SNAPSHOT docker images should be considered bleeding edge, but latest = stable

lispyclouds11:04:25

totally agreed

borkdude11:04:48

In the next commit we should have BOLD CAPITALS in that logic which only pushes to latest on non-SNAPSHOT

lispyclouds11:04:02

i found the issue too, wasnt checking if version contains snapshot, but is snapshot 😞

❤️ 1
borkdude11:04:56

@UFUKJ3QG7 Should be fixed now - can you test?

lispyclouds11:04:07

moving to #babashka-sci-dev for the PR

Erkan11:04:56

I just used the :latest

Erkan11:04:57

Yarr :latest works again!

borkdude11:04:29

😅 ! Thanks for moving so fast @rahul080327

lispyclouds11:04:09

well more eyes on the review next time!

lispyclouds13:04:53

@UFUKJ3QG7 could you try out babashka/babashka:0.8.1-SNAPSHOT too once if possible? wanna make fully sure the archs are correct 😄

borkdude13:04:24

What I'm seeing on amd64:

$ docker run --rm babashka/babashka:0.8.1-SNAPSHOT bb -e '(+ 1 2 3)'
Unable to find image 'babashka/babashka:0.8.1-SNAPSHOT' locally
0.8.1-SNAPSHOT: Pulling from babashka/babashka
e0b25ef51634: Pull complete
bf3385f5392f: Pull complete
4a72072863da: Pull complete
7f9ab196048c: Pull complete
4f4fb700ef54: Pull complete
Digest: sha256:de4a585a4f7cde6a41a3a623e2205622730cb7a7e31bba9672f982c0d0eed4fa
Status: Downloaded newer image for babashka/babashka:0.8.1-SNAPSHOT
6

Erkan13:04:32

seems to work for me

1
borkdude15:04:12

Video is still being rendered by youtube, check back later for higher quality.

lispyclouds16:04:20

all better now 😄

hairfire18:04:55

@borkdude is it reasonable to add something like cwdto babashka.fs that returns the Current Working Directory? At the moment I'm doing this (:out (sh "pwd")).

lispyclouds18:04:58

you could also do (System/getProperty "user.dir")

✔️ 1
borkdude18:04:05

What @rahul080327 said is the recommended way, but yes, we could just make a function that does that

😁 1
borkdude18:04:29

Any opinions for a name for a function in babashka.fs that returns the value (System/getProperty "user.dir") aka PWD in bash shells? • cwdworking-dir / working-directorycurrent-working-directory • ...

Darin Douglass18:04:19

i’m partial to working-dir(ectory)

lread20:04:10

I like current-working-directory for its explicitness, but I don’t think too many folks would be confused by cwd.

ahungry02:04:42

can't go wrong with pwd either 🙂 (print working directory - not quite printing, but getting the string representation of it, close enough) - of the options given, I like cwd - the more bash'isms the better, not familiar with the lib, but ls for listing the dir (getting the files as an array of maps or strings) would also be great

lread04:04:53

Yeah maybe not.. if we have a pwd-str it likely implies we also have a pwd.

Joshua Suskalo15:04:16

oh I thought pwd stood for "path to working directory"

lread17:04:34

Oh maybe you are right @U5NCUG8NR, I always thought p meant print. But that doesn’t really make sense for the PWD env var.

ahungry11:04:27

definitely seems to work as either acronym tho!

borkdude18:04:54

Has anyone ever stumbled upon rrb-vector being necessary for a dependency you tried to run in bb?

borkdude20:04:58

And that depends on puget which depends on fipp which depends on rrb-vector. It all leads to fipp

cldwalker20:04:22

Ah. Bummer. Dunno if he understood that when he said upstream the issue

papachan19:04:36

It seems bb install have been broken when trying to install it from Scoop ( windows ). when i try to launch it, it always asks me about where is located the exe file.

borkdude19:04:14

yes, this was the unfortunate effect of doing another 0.8.0 release to fix docker images which were accidentally overwritten due to a bug in a PR.

1
borkdude19:04:29

@ales.najmann could you maybe update the scoop package so it will pick up the newest SHA for the (new) 0.8.0 release?

borkdude19:04:04

Maybe it's better to just release 0.8.1

borkdude19:04:40

Let me just do that

littleli19:04:50

Yeah. Bumping the version fixes this. Autoupdate process is driven by versions.

borkdude19:04:04

Babashka 0.8.1 (2022-04-15) • Add prepare subcommand to download deps & pods and cache pod metadata • https://github.com/babashka/babashka/issues/1041: Improve error message when regex literal in EDN config • https://github.com/babashka/babashka/issues/1223: Ensure that var metadata (specifically :name) aligns with the var's symbol (which in turn ensures that doc will print the var's name) • https://github.com/babashka/babashka/issues/556 Add server-status to org.httpkit.server • https://github.com/babashka/babashka/issues/1231: missing methods in reify should fall back to default interface methods • Fix destructuring in defrecord protocol impls • Support *print-dup*

🚀 4