Specifying the envvar using the :extra-env param for the clojure command doesn't work, because this affects the environment of the clojure process started with the classpath, not the environment of the process that computes the classpath. Similarly, adding -J-Dclojure.gitlibs.dir=.gitlibs to the command does not work. But surprisingly (to me) it also does not work to set the property directly, as in the following example:

{:tasks
 {foo (do
        (System/setProperty "clojure.gitlibs.dir" ".gitlibs")
        (clojure (str "-Sforce -Sdeps "
                      "'{:deps {io.github.cognitect-labs/test-runner "
                      "         {:git/url \"\""
                      "          :sha \"705ad25bbf0228b1c38d0244a36001c2987d7337\"}}}' "
                      "-Spath")))}}

Ah, can you make an issue for this?

I think -J-Dclojure.gitlibs.dir=.gitlibs should at least work. Which version are you on?

There was a fix regarding option parsing in 0.4.5

I'm on 0.4.6. I don't think that will work - it also does not work with the clojure CLI, because the classpath is computed by a different jvm process which does not get java_opts from -J args

aaah right

so from the Clojure CLI perspective, what is the expected way of doing this?

I don't know! As far as I could tell from inspecting the clojure bash script, there's no way of specifying java_opts for that process

so I guess the expected way of doing it is to set GITLIBS in the environment

I can make an issue in the babashka project – feel free to close it if you think it belongs somewhere else

yes, that's fine

I would have expected the tools deps step to have picked up that env var

Which one? The one from (System/setProperty "clojure.gitlibs.dir" ".gitlibs")?

the :extra-env one

Ah, so (clojure {:extra-env {"GITLIBS" ".gitlibs"}} ,,,)

yes, that's what I expected to work, but I'm testing it now and it appears it doesn't

This does work:

{:tasks
 {foo (do
        (shell {:extra-env {"GITLIBS" ".gitlibs"}}
                 (str "clojure -Sforce -Sdeps "
                      "'{:deps {io.github.cognitect-labs/test-runner "
                      "         {:git/url \"\""
                      "          :sha \"705ad25bbf0228b1c38d0244a36001c2987d7337\"}}}' "
                      "-Spath")))}}

that's invoking the system-installed Clojure version

but I still would like to have an issue for this so it can be fixed

Ah yes, of course. That should be good enough for now, although not as satisfying as using the deps.clj.

I'll make an issue.

Sorry, I pressed "enter" before I filled out the issue - there's content on it now https://github.com/babashka/babashka/issues/934

:)

I see the issue, I'm not using babashka.process for the tools deps step

so the :extra-env option does nothing for that step

So the classpath computation is done within the bb process?

In that case, shouldn't (System/setProperty "clojure.gitlibs.dir" ".gitlibs") have an effect?

No, the tools deps step is a separate JVM

but this JVM isn't started using babashka.process which processes the :extra-env option

Aah

but using some custom ProcessBuilder code that was there since the beginning in deps.clj

@UNBM99ED7 I think I have a solution. Can I provide you with a binary for testing?

Awesome 🙂 Yes, I'll test

linux, mac?

windows?

Mac

https://20854-201467090-gh.circle-artifacts.com/0/release/babashka-0.4.7-SNAPSHOT-macos-amd64.tar.gz

It works! With (clojure {:extra-env {"GITLIBS" ".gitlib"}} ,,,)

yay!

I'll write a test for it and hopefully this week there will be a new proper release

Amazing! 🙂 Thanks for all your work!

That means I can put something like this in my :init job

(def clj
    (if (some-> (System/getenv "CI") (not= "0"))
      (partial clojure
               {:extra-env {"GITLIBS" ".gitlibs"}}
               "-Sdeps '{:mvn/local-repo \".m2-repo\"}'")
      clojure))

if it's easier for you, you can also provide the deps map as a separate string without the single quotes

I think even just the quoted EDN map will work

since the conversion to string is done automatically

Indeed that works. Much prettier