babashka 2020-10-15 | Slack Archive

@isak Status should be a BList of BString, not a JSON-ized value

@borkdude nice, it works now with that fix, thanks!

Btw, I noticed the process used by the pod doesn't get killed when the script finishes on windows unless unload-pod is called. Is that by design?

borkdude14:10:39

that's not by design. the process should be killed, since there is a shutdown hook that will destroy the process.

borkdude14:10:33

@isak https://github.com/babashka/babashka.pods/blob/dd46020efcc39404a105e6d9323b07ab2d0fffc8/src/babashka/pods/impl.clj#L304

borkdude14:10:41

Maybe for some reason this doesn't work on windows?

isak14:10:57

Hmm, it looks like the destroy function expects a pod-id, but is sent a pod

borkdude15:10:42

Hmm, you're right, this may be a bug...

isak15:10:47

Maybe other operating systems destroy subprocesses automatically, and windows doesn't. (I have noticed windows does not via .NET (unless you make some special calls, for example)

borkdude15:10:56

yeah, could be the case. I'll fix

borkdude15:10:52

I pushed a fix. You can find a new binary in the Appveyor build in a few minutes.

borkdude15:10:24

https://ci.appveyor.com/project/borkdude/babashka/builds/35772182

borkdude15:10:37

hmm, wait a minute, I broke something

borkdude16:10:09

@isak This one should work: https://ci.appveyor.com/project/borkdude/babashka/builds/35772827/artifacts

isak16:10:59

@borkdude that worked, thanks!

borkdude16:10:41

woohoo! thanks for spotting the mistake

borkdude16:10:47

I added support for transit+json payloads in babashka pods on master. This can be useful for sending over bytes, dates, etc.

😎 3

🍾 3

2020-10-15

Channels