babashka-sci-dev

lispyclouds 2022-05-28T19:30:48.621789Z

@borkdude first cut from @brzoskwinka18 https://github.com/babashka/babashka/pull/1282 😄

borkdude 2022-05-28T19:31:49.337429Z

@brzoskwinka18 That's awesome! Welcome!

agata_anastazja (she/her) 2022-05-28T19:32:01.968109Z

thank you!

borkdude 2022-05-28T19:32:33.716699Z

So, as discussed earlier, perhaps we could install the bb to a different directory and rename it, and then call it, as too not confuse that bb with the bb we're building

borkdude 2022-05-28T19:33:13.971699Z

You can do this with:

--dir /tmp/foobar
or so. And then mv /tmp/foobar/bb /tmp/foobar/bbb

borkdude 2022-05-28T19:33:24.642389Z

And then call /tmp/foobar/bbb short.clj

agata_anastazja (she/her) 2022-05-28T19:34:17.674789Z

I thought about it, but if it's a separate job, it's going to be isolated anyway. But if you would rather it be done this way, I can change it 🙂

borkdude 2022-05-28T19:36:01.687629Z

Ah right, it's a separate job, good point.

borkdude 2022-05-28T19:36:37.689599Z

Still, I think it's a good idea to do this, I will shoot myself in the foot one way or another - I know myself too well ;)

borkdude 2022-05-28T19:37:23.874629Z

E.g. some people will copy what you did here to another job, and I won't think about it anymore

agata_anastazja (she/her) 2022-05-28T19:40:14.237399Z

alright!

❤️ 1
borkdude 2022-05-28T19:58:25.133359Z

@brzoskwinka18 I'm really happy with the PR. In case you want some minor feedback (I'm already happy to merge this):

borkdude 2022-05-28T19:59:44.201789Z

For commands where you need the :out :string you could also use: https://github.com/babashka/process/blob/master/API.md#sh That also blocks. But doesn't throw, so you still need to call check. There is also babashka.tasks/shell: (shell {:out :string} "git ...") which blocks and checks

borkdude 2022-05-28T20:00:09.069789Z

Again, I'm happy to just go ahead and merge this, it looks awesome. I'm happy @rahul080327 poked you about this :-)

borkdude 2022-05-28T20:01:39.755899Z

I will go ahead and merge this and if you want to change anything, just make another PR. Thanks again.

💜 1
lispyclouds 2022-05-28T20:03:04.266999Z

Yay! welcome to bb with your first OSS commit @brzoskwinka18! 😄

💜 1
borkdude 2022-05-28T20:03:31.146379Z

This was something I wanted to have for a very long time :)