@borkdude first cut from @brzoskwinka18 https://github.com/babashka/babashka/pull/1282 😄
@brzoskwinka18 That's awesome! Welcome!
thank you!
So, as discussed earlier, perhaps we could install the bb to a different directory and rename it, and then call it, as too not confuse that bb with the bb we're building
You can do this with:
--dir /tmp/foobar
or so.
And then mv /tmp/foobar/bb /tmp/foobar/bbbAnd then call /tmp/foobar/bbb short.clj
I thought about it, but if it's a separate job, it's going to be isolated anyway. But if you would rather it be done this way, I can change it 🙂
Ah right, it's a separate job, good point.
Still, I think it's a good idea to do this, I will shoot myself in the foot one way or another - I know myself too well ;)
E.g. some people will copy what you did here to another job, and I won't think about it anymore
alright!
@brzoskwinka18 I'm really happy with the PR. In case you want some minor feedback (I'm already happy to merge this):
For commands where you need the :out :string you could also use:
https://github.com/babashka/process/blob/master/API.md#sh
That also blocks. But doesn't throw, so you still need to call check. There is also babashka.tasks/shell: (shell {:out :string} "git ...") which blocks and checks
Again, I'm happy to just go ahead and merge this, it looks awesome. I'm happy @rahul080327 poked you about this :-)
I will go ahead and merge this and if you want to change anything, just make another PR. Thanks again.
Yay! welcome to bb with your first OSS commit @brzoskwinka18! 😄
This was something I wanted to have for a very long time :)