Fork me on GitHub
#babashka-sci-dev
<
2022-05-28
>
borkdude19:05:49

@brzoskwinka18 That's awesome! Welcome!

borkdude19:05:33

So, as discussed earlier, perhaps we could install the bb to a different directory and rename it, and then call it, as too not confuse that bb with the bb we're building

borkdude19:05:13

You can do this with:

--dir /tmp/foobar
or so. And then mv /tmp/foobar/bb /tmp/foobar/bbb

borkdude19:05:24

And then call /tmp/foobar/bbb short.clj

agata_anastazja (she/her)19:05:17

I thought about it, but if it's a separate job, it's going to be isolated anyway. But if you would rather it be done this way, I can change it 🙂

borkdude19:05:01

Ah right, it's a separate job, good point.

borkdude19:05:37

Still, I think it's a good idea to do this, I will shoot myself in the foot one way or another - I know myself too well ;)

borkdude19:05:23

E.g. some people will copy what you did here to another job, and I won't think about it anymore

agata_anastazja (she/her)19:05:14

alright!

❤️ 1
borkdude19:05:25

@brzoskwinka18 I'm really happy with the PR. In case you want some minor feedback (I'm already happy to merge this):

borkdude19:05:44

For commands where you need the :out :string you could also use: https://github.com/babashka/process/blob/master/API.md#sh That also blocks. But doesn't throw, so you still need to call check. There is also babashka.tasks/shell: (shell {:out :string} "git ...") which blocks and checks

borkdude20:05:09

Again, I'm happy to just go ahead and merge this, it looks awesome. I'm happy @rahul080327 poked you about this :-)

borkdude20:05:39

I will go ahead and merge this and if you want to change anything, just make another PR. Thanks again.

💜 1
lispyclouds20:05:04

Yay! welcome to bb with your first OSS commit @brzoskwinka18! 😄

💜 1
borkdude20:05:31

This was something I wanted to have for a very long time :)