Fork me on GitHub
#babashka-sci-dev
<
2022-05-26
>
lispyclouds19:05:51

For the CI shorting script, need some opinions: • includes vs excludes: we short when file(s) in the changeset are in either of the lists? • how to specify the files: as a vec of strings of globs or direct file paths or regexes? • should we also support git message based shorting? • how much should the script be aware of where its running: should it signal a short by a non zero exit or call some ci-centric API/shell command? • if this is written using bb, should we bootstrap it?

borkdude19:05:33

@rahul080327 I'm mostly concerned about circleci, so we can just use the circleci short command which is already in there somewhere. Also as a first iteration, just filtering on only .md files is sufficient: if the changed files are only .md files, then short, that's it. This is what I need for clj-kondo and babashka, nothing more complex at the moment.

lispyclouds20:05:32

okay so this is what I'll start with the logic short by calling the circleci command if includes only *.md. for the bb question, should be bootstrap it like the docker script?

borkdude20:05:38

ah right. yeah, bootstrap seems good

lispyclouds20:05:04

here i think we need to use a pre built bb? cant do it exactly like the docker one as its pretty much at the end.

borkdude20:05:26

maybe since this will be a simple script, hopefully, some bash would be ok...? famous last word

borkdude20:05:56

I'd rather not have a bb within the bb build as I'm afraid that it will mess things up

lispyclouds20:05:43

or python maybe? have some sanity than bash

lispyclouds20:05:55

can just use jvm clj

borkdude20:05:15

or maybe we could download bb to a /tmp/build dir

borkdude20:05:22

with --dir /tmp/build

borkdude20:05:31

and then explicitly invoke it via /tmp/build/bb ...

lispyclouds20:05:50

yeah im all for isolating the other bb

borkdude20:05:00

The installer script supports that. Let's go with that

borkdude20:05:28

And then maybe rename it to bb-build too, just to be sure

lispyclouds20:05:04

sounds good to me, would have a go at it in a day or so. have a fair idea now

borkdude20:05:16

nice, thanks

lispyclouds20:05:52

or this could also be the first tools.build thing too

borkdude20:05:07

please not, tools.build is a build tool, let's not spawn JVMs within JVMs for simple stuff

borkdude20:05:50

I will eventually rework the feature stuff with tools.build, it's a natural fit for that

1
borkdude20:05:42

Just a .clj file will also do, we should be able to run that either with JVM or a bespoke bb download

lispyclouds20:05:00

probably would be a bb centric clj file, would involve shelling out to git, gotten hooked to bb.process now 😄

borkdude20:05:27

yeah, all the deps are there anyway :)