@rahul080327 I quite love the bb compatible badge you came up with! I've added to https://github.com/clj-commons/etaoin#etaoin (which will very soon be bb compatible!).

It is currently a bit on the large side tho making it a bit hard to paste into a doc. It took me a while to get it right for adoc for example. If sticking with http://shields.io I think there is https://shields.io/endpoint? Would that be a way to make the link more regular size?

Nice! Didn't know of the backend support, will try that out now! Thanks! had the same issue for me in adoc https://raw.githubusercontent.com/babashka/book/master/src/libraries.adoc

I guess it might imply you need to host something somewhere? But maybe it could be a pointer to some json in a github repo, I really don't know.

@borkdude can we host that json on a path on http://babashka.org?

@rahul080327 probably it can just live in a git repo and then you can just request it via raw.github?

yeah i can host it on a repo of mine, was thinking if its more consistent if its served from a repo where all the docs are. maybe beside the logos in the logos/ dir of babashaka?

yeah, I was also thinking in a bb repo and the logos directory makes sense to me

will test this out on my things, polish it and send a PR along

another option, maybe simpler, save the final rendered badge and add it to the logos 😛

:-D

dont do the shields round trip

It is static, so that should work, right?

i think so

looks okay i think?

But does Github allow you to embed svgs from other locations?

https://github.com/babashka/babashka/pull/1275

I guess so

@rahul080327 skip ci ;)

ahhhh

will do the script asap

not sure why the other commit is there

maybe branched wrong

But while you're at it the musl and windows builds seem to be failing as well :/

yeah branched wrong

ah ok

fixed

:-D

cancelling circle

it doesn't seem to work with raw, right? https://raw.githubusercontent.com/babashka/babashka/master/logo/badge.svg

looks okay to me

I don't see the bb logo

ah

Refused to load the image 'data:image/svg+xml;base64,PHN2ZyB3aWR0aD0iMTQiIGhlaWdodD0iMTQiIHZpZXdCb3g9IjAgMCAxNDcyIDE0NzIiIGZpbGw9Im5vbmUiIHhtbG5zPSJodHRwOi8vd3d3LnczLm9yZy8yMDAwL3N2ZyI+CjxwYXRoIGZpbGwtcnVsZT0iZXZlbm9kZCIgY2xpcC1ydWxlPSJldmVub2RkIiBkPSJNOTk1LjkxMSAxMTkzLjg5QzExMTAuOTMgMTExMi4zOCAxMTg2IDk3OC4yMDYgMTE4NiA4MjYuNUMxMTg2IDU3Ny45NzIgMTAxNCAyNTQuNSA3MzYgMTEzQzQ2MC41IDI2MiAyODYgNTc3Ljk3MiAyODYgODI2LjVDMjg2IDk3OC4yMDYgMzYxLjA3IDExMTIuMzggNDc2LjA4OSAxMTkzLjg5QzQ3MS45ODMgMTE5NC40NCA0NjcuOTQ5IDExOTUuMTQgNDY0IDExOTZDMzc2LjYxMSAxM...c4NC45MTggNDkwLjk1NyA3ODcuNjkzIDQ5My40NjEgNzk2LjU3NUw0OTkuMzAzIDgxNy4xMTNMNDQ3IDk1Mkg0ODUuMTE1TDUxNi41NTMgODYzLjE4NUw1MzMuMjQ1IDkxNi43NTJDNTM5LjY0NCA5MzcuNTY4IDU1MC40OTQgOTUyIDU3NC45NzcgOTUySDU5MFoiIGZpbGw9IndoaXRlIi8+CjxkZWZzPgo8bGluZWFyR3JhZGllbnQgaWQ9InBhaW50MF9saW5lYXIiIHgxPSI3NTIiIHkxPSIxMTMiIHgyPSI3NTIiIHkyPSIxMzU5LjUyIiBncmFkaWVudFVuaXRzPSJ1c2VyU3BhY2VPblVzZSI+CjxzdG9wIHN0b3AtY29sb3I9IiNFNDFGMjYiLz4KPHN0b3Agb2Zmc2V0PSIxIiBzdG9wLWNvbG9yPSIjQjcwMDAwIi8+CjwvbGluZWFyR3JhZGllbnQ+CjwvZGVmcz4KPC9zdmc+Cg==' because it violates the following Content Security Policy directive: "default-src 'none'". Note that 'img-src' was not explicitly set, so 'default-src' is used as a fallback.

This is what I assumed. Did you test this on another git repo first?

no tried rendering the readme, assuming its all local it should render

if it works in the README then it's fine my me

did you add it here? https://github.com/babashka/babashka#projects

its weird that its not a remote link and still refuses to load

that seems to work fine

Now, does it also work from the etaoin repo? @lee

> did you add it here? yes it seems to render correctly on master

Testing now…

Works! Thanks @rahul080327! https://github.com/clj-commons/etaoin/commit/28de96fe06c8dceeac438609faafc9e620996304

yay!

i guess github's backend markdown rendering saves the remote request thing in browsers 😅

:-D

@borkdude will have a look at the CI things hopefully today evening, juggling work is quite the thing 😕

no problem

@borkdude do you have a log from the windows and musl failures? not sure which one of the latest failure(s) i should look at, some of them have passed too

if the tests are passing now, I think we're good - as you said, it might be because of of a weird merge?

I'll ping you again when something happens

cool!

yeah i was on a different machine and the branch i did was 100s of commits behind and the ci was building that, rebased it and its good