babashka-sci-dev

lispyclouds 2022-05-08T07:38:47.101699Z

@borkdude only ran Mac, here's the artifacts: https://github.com/babashka/babashka/actions/runs/2288883190 Quite slow but seems to work, probably okay to merge, can remove the jvm step too if needed

borkdude 2022-05-08T07:39:27.066669Z

nice!

lispyclouds 2022-05-08T07:40:47.105929Z

the build uberjar varies from 1.something min to 4 worst case

borkdude 2022-05-08T07:41:41.198359Z

is that because of dependency downloading?

lispyclouds 2022-05-08T07:42:20.904059Z

i guess so, maybe the cache wasnt there

lispyclouds 2022-05-08T07:42:46.790129Z

yesterday was running in a min or so, last one today was really bad

lispyclouds 2022-05-08T07:43:04.118849Z

should we disable the JVM step too? like docker is

lispyclouds 2022-05-08T07:44:08.632899Z

it is a parallel one and the mac step would almost certainly over run it

lispyclouds 2022-05-08T07:45:54.727309Z

also bumping up to mac-12 like circle is

borkdude 2022-05-08T07:46:26.417809Z

what still bothers me about github actions is that they build the same commit twice if you do: on: push, pull_request

borkdude 2022-05-08T07:46:39.510899Z

it bothered me a couple of years ago and they still haven't fixed that

lispyclouds 2022-05-08T07:48:41.449339Z

well looking at the last runs, its this event called synchronize and not seeing dups

lispyclouds 2022-05-08T07:49:19.899879Z

it happens when its both on master and a PR is it? failing to remember

borkdude 2022-05-08T07:51:04.201419Z

borkdude 2022-05-08T07:51:21.240079Z

That was the SCI pr

lispyclouds 2022-05-08T07:53:58.882149Z

ah right, something when its merged

lispyclouds 2022-05-08T07:54:25.773119Z

well here if we are only running mac, not too bad hopefully

lispyclouds 2022-05-08T08:07:50.391039Z

I think we're good to go, will add back the circle jobs without mac maybe?

lispyclouds 2022-05-08T08:26:39.690459Z

changed the required mac check from circle to actions

borkdude 2022-05-08T08:31:19.983929Z

Merged!

borkdude 2022-05-08T08:32:52.238069Z

Does Github have a limit to what you can run on OSS projects?

lispyclouds 2022-05-08T08:33:33.398349Z

2000 mins/month iirc

lispyclouds 2022-05-08T08:34:55.319989Z

and apparently if we have:

on:
  push:
    branches:
      - master
  pull_request:
    branches:
      - master
the dup event shouldnt run, otherwise the behaviour is expected it seems: https://github.community/t/duplicate-checks-on-push-and-pull-request-simultaneous-event/18012

borkdude 2022-05-08T08:36:11.099719Z

thanks. I never understood this and probably never will, I loved that CircleCI just did what I expected without any config - anyway moving on ;)

lispyclouds 2022-05-08T08:36:49.196689Z

yeah lets add it because 🤷🏼

borkdude 2022-05-08T08:38:01.188499Z

Isn't the 2000 minute limit limited to private projects only?

borkdude 2022-05-08T08:38:22.406849Z

Does gitlab and co also offer something like this?

borkdude 2022-05-08T08:39:06.161699Z

> GitHub Actions usage is free for both public repositories and self-hosted runners. For private repositories, each GitHub account receives a certain amount of free minutes and storage, depending on the product used with the account.

lispyclouds 2022-05-08T08:39:09.794899Z

since you can have no limits on private repo count they dont differentiate i guess

borkdude 2022-05-08T08:39:38.833039Z

>> For private repositories, each GitHub account receives a certain amount of free minutes and storage,

lispyclouds 2022-05-08T08:39:58.430499Z

well thats helpful 😕

borkdude 2022-05-08T08:40:24.676709Z

I optimistically read that as in public repos have no limit ;)

borkdude 2022-05-08T08:40:45.787499Z

Maybe clj-kondo next? We could maybe wait with all of the pods until CircleCI have solved the problem

lispyclouds 2022-05-08T08:45:34.308289Z

we could drop the jvm job from actions, save about ~8 mins/run

borkdude 2022-05-08T08:45:46.518329Z

yeah

lispyclouds 2022-05-08T08:46:34.929419Z

maybe you can add the if: false thing to it like i did for docker?

👍 1
lispyclouds 2022-05-08T08:47:02.391419Z

im looking into kondo soon

borkdude 2022-05-08T08:47:30.196569Z

sure! enjoy the weekend too :)

borkdude 2022-05-08T08:47:43.123379Z

thanks for stepping in

lispyclouds 2022-05-08T08:47:46.618869Z

😄