babashka-sci-dev

Bob B 2022-04-03T16:06:38.401889Z

I might just be missing some history, but I'm concerned I'm missing a file or something - sci's native test script has a performance test that runs tests from sci.performance-test - in my local and in the CI run I looked at from yesterday, that invocation runs 0 tests, 0 assertions. Based on everything I can see, there are currently no performance tests to be run, but I'm wondering: • was this test ns removed intentionally? (just want to make sure it wasn't an accident to be addressed) • should we remove that test to eliminate a lein invocation? (or is it there so if performance tests come back, they'll get run without having to remember to re-add it)

borkdude 2022-04-03T16:11:00.512739Z

They might have been removed, don't worry about that

borkdude 2022-04-03T16:11:21.178049Z

And yes, if that file isn't there anymore, the lein invocation can go

teodorlu 2022-04-03T20:56:38.775389Z

Hi 👋

👋 1
teodorlu 2022-04-03T20:59:31.418439Z

PR: Add neil dep add entrypoint. Exactly the same as neil dep add - but fits with neil dep versions. https://github.com/babashka/neil/pull/19

borkdude 2022-04-03T21:00:02.036979Z

Merged :)

🎉 1
teodorlu 2022-04-03T21:02:47.534369Z

Would you like CI too before cutting a release?

borkdude 2022-04-03T21:05:14.781699Z

@teodorlu I published version 0.0.18 now. A CHANGELOG.md and CI would be swell. Also feel free in #announcements what you've done.

👀 1
borkdude 2022-04-03T21:06:57.818679Z

About CI: I usually use https://github.com/turtlequeue/setup-babashka - works pretty well, but just bash installer script works too. Merged.

teodorlu 2022-04-03T21:08:56.026019Z

Ah, nice. Didn't know there was an existing action for adding babashka.

borkdude 2022-04-03T21:09:41.727859Z

Should the help reflect neil dep add as well?

teodorlu 2022-04-03T21:10:53.354379Z

Good catch.

borkdude 2022-04-03T21:09:55.593489Z

I'm tuning out for today, thanks a lot!

teodorlu 2022-04-04T10:38:36.481059Z

@borkdude I guess I should have pinged you about that one ☝️ 😄

borkdude 2022-04-04T10:39:16.515019Z

oh thanks :)

teodorlu 2022-04-03T21:11:37.939669Z

My pleasure!

borkdude 2022-04-03T21:50:10.855089Z

Awesome announcement. Perhaps that fzf info can also end up in the README

🙌 1
🤔 1
borkdude 2022-04-03T21:51:44.577819Z

This is really beautiful:

$ neil dep versions org.clojure/clojure | fzf | xargs neil dep add

🤗 1
teodorlu 2022-04-03T21:54:09.943279Z

Unix pipes are great 😄

borkdude 2022-04-03T22:00:53.640019Z

If you want to make a tweet about this, with your video, I'll RT ;)

🤔 1
teodorlu 2022-04-03T22:05:16.094689Z

Looks like I forgot to run bb run gen-script for https://github.com/babashka/neil/pull/21.

borkdude 2022-04-03T22:05:48.521719Z

@teodorlu No problem, that'll happen automatically when I run bb publish again.

👍 1