Clojurians Log v2

I noticed this takes pretty long on my machine:

(deftest uberjar-with-pods-test
  (testing "jar contains bb.edn w/ only :pods when bb.edn has :pods"
    (let [tmp-file (java.io.File/createTempFile "uber" ".jar")
          path (.getPath tmp-file)]
      (.deleteOnExit tmp-file)
      (let [config {:paths ["test-resources/babashka/uberjar/src"]
                    :deps '{local/deps {:local/root "test-resources/babashka/uberjar"}}
                    :pods (cond-> '{org.babashka/go-sqlite3 {:version "0.1.0"}}
                            (not (fs/windows?)) (assoc 'pod/test-pod {:path "test-resources/pod"
#_:here->                                                             :cache true}))}]
        (tu/with-config config
          (time (tu/bb nil "uberjar" path "-m" "my.main-pod"))
          (let [bb-edn-entry (get-entry tmp-file "bb.edn")
                bb-edn (-> path JarFile. (.getInputStream bb-edn-entry)
                           InputStreamReader. PushbackReader. edn/read)]
            (is (= #{:pods} (-> bb-edn keys set)))
            (is (= (:pods config) (:pods bb-edn))))
          (is (str/includes? (tu/bb nil "--jar" path) "3")))))))

although I set cache true

it's because of the local pod

I noticed it doesn't get anything from a cache

it's weird actually, creating the uberjar takes a long time... why, it doesn't actually have to load the pods at all I guess

oh maybe it does load those pods while it shouldn't have to, in the uberjar task

but anyway, it seems caching also didn't work, so two issues: • cache for local path does not seem to do anything? • loading of pods for namespaces can be prevented when creating an uberjar

Maybe the second one is not important, since we usually do downloading of deps etc too in the first usage of whatever. So it's mostly: why wasn't the cache working I guess

Or was that because the test uses a different dir each time? That could be

Yeah different dir is the likely culprit

I can work on optimizing that test a bit if you don't beat me to it :)

Otherwise local pod caching should be enabled when you don't opt out of it

Ah right. No, it's fine

And look into not loading pods when building an uberjar

Maybe not so important since when things are cached it won't take time

But might be good double checking if the caching is still ok in both registry and local pods

There are many things that do not need deps loading and pod caching, but we do it anyway, so I think it's best to leave it

Good question...

I don't even know why we have sym to be honest. We could get the name from the metadata

unless we need to have a proper field for perf reasons

Maybe you could get an overview where we need the sym field and how it's typically used, in what functions

Then we could decide to either get rid of it and do it via the metadata or fix the field properly

from what I've seen, the actual sym field looks like it's primarily (maybe entirely?) used within the deftype

... and then other places call getName . I'll do some digging

Well, I've got all the sci tests passing with no references to the sym field (all the direct references are in the methods defined in the deftype), so it's doable entirely via metadata (notwithstanding potential performance concerns). My primary concern would be babashka, which, in a couple spots, creates SciVars without metadata (and quite possibly other consumers of Sci that might be calling the SciVar constructor directly instead of going through new-var.

Have you found out what potential performance implications might be? When is .getName called, typically? And what happens in the absence of the symbol?

One should not create SciVars directly, but always via the sci.core namespace, so I'll accept that breakage

(there's still places in bb where I call into .impl namespaces)

I only see one call to getName on a SciVar, and that's on an exception path to throw when someone tries to change a built-in var. All the uses of sym appear to be when getting a symbol/string to print a var name.

I'm convincing myself more and more that this is a good idea to go after:

before:
(->> (find-ns 'rewrite-clj.zip) ns-publics (take 5))
([child-sexprs #'child-sexprs] [tag #'tag] [insert-space-left #'insert-space-left] [postwalk #'postwalk] [whitespace? #'whitespace?])

after:
(->> (find-ns 'rewrite-clj.zip) ns-publics (take 5))
([child-sexprs #'rewrite-clj.zip/child-sexprs] [tag #'rewrite-clj.zip/tag] [insert-space-left #'rewrite-clj.zip/insert-space-left] [postwalk #'rewrite-clj.zip/postwalk] [whitespace? #'rewrite-clj.zip/whitespace?])

nice

Great!