This page is not created by, affiliated with, or supported by Slack Technologies, Inc.
2021-12-10
Channels
- # adventofcode (54)
- # announcements (30)
- # asami (13)
- # aws (10)
- # babashka (16)
- # babashka-sci-dev (44)
- # beginners (95)
- # calva (63)
- # clara (10)
- # clj-kondo (3)
- # cljfx (6)
- # cljs-dev (7)
- # cljsrn (1)
- # clojure (68)
- # clojure-europe (59)
- # clojure-nl (7)
- # clojure-norway (12)
- # clojure-spec (6)
- # clojure-uk (6)
- # clojurescript (4)
- # component (4)
- # conjure (5)
- # datomic (3)
- # deps-new (1)
- # events (4)
- # exercism (1)
- # figwheel-main (1)
- # fulcro (33)
- # gratitude (1)
- # improve-getting-started (3)
- # jobs (3)
- # lsp (5)
- # malli (10)
- # membrane (5)
- # music (3)
- # nextjournal (6)
- # off-topic (42)
- # pedestal (2)
- # polylith (14)
- # portal (11)
- # re-frame (42)
- # releases (3)
- # reveal (4)
- # shadow-cljs (62)
- # tools-build (1)
- # tools-deps (3)
- # web-security (1)
- # xtdb (3)
@rahul080327 @borkdude let me know if my comments on the PR don't make sense. I've had to learn a lot about multi-platform docker builds lately and it is a lot 🙂
Its looking really nice @cap10morgan I'm learning about it too! knew a bit about manifest but mostly hid behind the buildx
😅 awesome stuff!
🙂 yeah I hadn't done much w/ manifest before either. I'm ripping it out of my PR now though haha
here goes nothin...
oh except it won't do anything interesting b/c of the branch filters. I'll let if run on this branch too for now.
there we go
Oh but it's still a snapshot so no joy
yeah that would let it trigger, but I think I need to do it on my branch. so probably easier if I just do it. BUT I'm nervous about letting it clobber those images on Docker Hub...
ok good! 🙂
alright giving that a shot
hmm, got a test failure that seems unrelated / intermittent, but I don't have perms to re-run. I guess I can push another dummy commit though if you don't mind the clutter 🙂
pushed
hahaha, oh boy. the check in the .circleci/script/docker
script is if [ -z "$CIRCLE_PULL_REQUEST" ] && [ "$CIRCLE_BRANCH" = "master" ]
so it still didn't run
given that .circleci/config.yml
already has branch filters and docker hub tokens aren't shared with pull requests, what do you think about just removing that?
I'm going to do it in this PR to test, but let me know if you'd like me to put it back before merging
yes, I agree of course. but I don't want to merge something that's untested!
these things are guarded against in other ways
but like I said, I'm happy to put it back before merging
for example, the docker
job won't even run in non-master branches due to the circleci config
hence why I had to whitelist my branch
sure thing
luckily the version change made it non-mergeable so you can't even do it accidentally now 😅
woof, more unrelated test failures
also comment out the jvm stuff, etc, everything you don't need to for testing and to get faster feedback
sounds good I'll do all that if I get another failure
I was thinking we could have a skip-tests
filter to skip tests in branches if you're not interested in those
that's a good idea
haha and this time it got as far as not having docker hub creds which is pretty early in the process. I should probably go back to having it push to my docker hub account and add that to the pre-merge checklist
think I'm wrapping up for the day too, though