Clojurians Log v2

Although I find awesome, I believe we could add this functionality in clojure-lsp which is used by Calva, and deliver this feature for all editors changing a single place via the clojure-lsp hover feature

I actually was planning to do that soon, but any help is welcome

I noticed that Calva gets its javadoc information "from nrepl", not from clojure-lsp. Better said: I see that nrepl-logging shows "javadoc" info comming in.

Interesting, via clojure-lsp seems better as wouldn't require repl connection :)

I know that in Calva there is a bit of overlap in taking things "from nrepl" and "from clojure-lsp". Some of this is configurable, if I remember well. Please have a look here, we have know more details on Calva javadoc support: https://calva.io/javadocs/ I have tried out what we say there, so I "believe" Calva takes javadoc info from nrepl... But I never checked the code..., I admit

The Calva settings read like this: Calva: Definition Provider Priority Calva can provide definitions using both the REPL connection and via clojure-lsp. Which provider should Calva prioritize when both are available? repl,lsp repl,lsp lsp,repl

yeah I know about that, It's just weird to me why one would prefer "javadoc that works" vs "javadoc that works, but require repl connected", if add this javadoc support for clojure-lsp

but yeah, I'm ok with that

But does clojure-lsp javadoc support rely as well on "source jars" being available on local disk ?

AFAIK if using the new clojure.java.doc, no?

indeed, but I mean "today" . Reading here: https://clojure-lsp.io/settings/#java-support seems to say that it can only find "javadoc" for the JDK classes, if src.zip is found. (but never for non-jdk classes) (which nrepl can)

ah yeah, for sure

But nrepl requires them to be "downloaded" by user. (so far). in form of "source jars" which are on maven central for most java open source libraries. Cider does this download automatic, but not nrepl

But indeed, know both clojure-lsp and nrepl have a new option (https://github.com/clojure/java.doc) to get to the javadoc. (not brand new, but easier)