Does it also recognize update-keys and update-vals?

(and I guess there will need to be a clojure-lsp release using this in order for it to benefit Calva users @UKFSJSM38?)

@U04V70XH6 it should recognize this automatically when you lint clojure 1.11

but good point, I should update that in clj-kondo proper

Yes @U04V70XH6 it's already on clojure-lsp master, it should be available on next release

@UKFSJSM38 can you check if update-vals is recognized in a project with clojure 1.11?

Thanks @UKFSJSM38 -- I asked because, for some reason, clojure-lsp had stopped running in my VS Code instance so I had to reload the "window" to restart it, and that made me curious as to which version is running: 2021.09.13-22.25.35, which uses clj-kondo 2021.08.07-SNAPSHOT

And that shows:

Unresolved symbol: update-keys

Tested with clojure-lsp master and it's working @U04V15CAJ

@U04V70XH6 even that version should work with update-keys iff you have .clj-kondo directory in that project so clj-kondo can save a cache of your linted deps

@U04V15CAJ even so, if the user change the deps to use a newer clojure (1.11), clojure-lsp would scan the analysis with clj-kondo

I did this test with clojure-lsp and it worked, finding update-keys and update-vals

because any change to project.clj or deps.edn triggers a new clojure-lsp full scan

@UKFSJSM38 How does LSP run the scan? Does it need to know about aliases? I have a monorepo and everything is behind a couple of aliases so, right now LSP doesn't always seem to startup, until I refresh the VS Code window, and it isn't scanning. I even deleted .lsp/sqlite.db to try to force that.

you can configure the classpath-command for every project

For multiple custom aliases, the best would be to configure th :project-specs in LSP

{:cljfmt {:indents {#re ".*" ns [[:inner 0] [:inner 1]]}}
 :auto-add-ns-to-new-files? false
 :project-specs [{:project-path "deps.edn"
                  :classpath-cmd ["clojure" "-A:dev" "-Spath"]}]}

ref: https://clojure-lsp.io/settings/#project

copied from the docs

Yeah, just trying to set that up... So I have a monorepo where the Clojure code is in a subdirectory so it looks like this:

<root>
    .clj-kondo/
    .lsp/
    clojure/
        deps.edn

is your clojure code inside clojure folder? if so why not import the clojure folder as the project root?

then everything should work right?

No, we have lots of other stuff in the root of the repo so the "project root" is as shown above, and we run the REPL in the clojure folder.

and then under clojure we have lots of subproject folders, each containing src, test, etc. Those are brought in via the aliases. Here's my config.edn right now:

{:project-specs [{:project-path "clojure/deps.edn"
                  :classpath-cmd ["clojure" "-Spath" "-M:build:dev:everything:runner:test"]}]}

@U04V70XH6 I checked the clojure-lsp code, and it will probably don't work as we run the clojure command in the project-root: https://github.com/clojure-lsp/clojure-lsp/blob/master/src/clojure_lsp/crawler.clj#L27

so maybe we could improve clojure-lsp to accept an optional path to run the classpath lookup command

otherwise that would just work if for clojure you import the clojure folder for now

How about if I add a shell script that cd's to clojure and then runs the clojure -Spath ... command and tell LSP that's the :classpath-cmd ?

that could work :)

maybe we could improve clojure-lsp to check if the project-file is inside another subfolder not on root and run the classpath-cmd from that folder

That would also solve the problem 🙂

yeah, feel free to open an issue about that :) Also, let me know if the script that cd into the folder and run the clojure command works as well

OK, well that did seem to work. LSP started and -- after a much longer initialization period this time! -- reports problems that make more sense. And, in particular, update-vals and update-keys are no longer flagged as unresolved /cc @U04V15CAJ

Sweet :)

the next startups should use the .lsp/.cache making it faster

@U076R6N1L This a great library that I'm already using! Thank you for it! Do you maybe plan to use lighter version of http client for Clojurescript? I would rather not include clojure.core.async , 🙏

I love the name

👽

@UJ1339K2B thanks! do you know of any ring-compatible cljs http clients (apart from cljs-http, which as you point out uses core.async)?

Unfortunetely no. Which means you would have to write such library yourself

it could be a fork of cljs-http to be honest, it should only be a small change

Yeah. But probably you would have to release a new artifact for it

There is https://github.com/lambdaisland/fetch but I guess it is not ring-compatible, whatever that means

@UJ1339K2B i did some hacking last night: https://github.com/oliyh/cljs-http-promise

and now https://github.com/oliyh/martian/tree/master/cljs-http-promise

This is so awesome! Thank you!!

🙂