thanks for your time on guiding the path @dominicm :)

It's not that related to clj-kondo, but since you're using the konmari metaphor, I thought you might find this tweet-thread interesting: https://mobile.twitter.com/sarahmei/status/783343170058788864

Goes beyond the "does this unit test spark joy?" joke to try to consider what the equivalent question might be for code.

This is tremendously cool. Great for learning more about the internals.

@U0ENYLGTA thanks for the newest release! It addresses some of the pain points we experienced during integrating this library. I know that you don’t accept PRs, still there are some improvements in my WIP fork that fixes issues, might be useful for some folks who can’t wait. 🙂 https://github.com/whitepages/aws-api/pull/1 Namely: - using https://github.com/ztellman/byte-streams so that the HTTP client body can be anything that is supported by the lib (open), instead of rolling your own protocol. It also removed lots of instance checking/manual type conversions in utils. - added the ability to override http client call at client + invoke site - add public endpoint to generate request map (as I think this is the primary value-add of your library along with handling of the response) - separate signing of request from sending it so HTTP client can modify headers, add custom User-Agent, etc. (also make it a client responsibility to sign so that other solutions can be used like: https://github.com/jerben/clj-aws-sign) - using a faster json parser: https://github.com/metosin/jsonista#performance

It’s not perfect, but I hope it gives you some ideas how some of the remaining items could be tackled. Cheers again! 🎉

@U08E8UGF7 thanks for the feedback and suggestions. Decoupling request generation, signing, and even the http-client itself are all on the radar. Stay tuned!