Clojurians Log v2

@robin.lahtinen Do you still think you'll get to it? Otherwise, lemme know and I'll try to wrap it up 🙂

Hey Rei, just submitted a PR for this! https://github.com/clj-commons/aleph/pull/779

@robin.lahtinen FYI: https://github.com/clj-commons/aleph/issues/772#issuecomment-4388119615

Be sure to update to 4.2.13 if you pick it up again and drop your commit which tries to work around the issue.

And ping if you can still observe it then 🙂

alright, finally on it now!

@robin.lahtinen No offense, but would you be so kind to disclose whether you used any LLM support in authoring this?

Asking specifically about the HTTP2 SETTINGS frame issue

Hi, yes, I used LLM. Sorry for not mentioning that earlier. I'll get back to your review and add comments and fixes. For the HTTP2 frame issue, it was blocking me from completing the test suite on my PC and was quite frustrating, and with some back-and-forth with LLM and reading Netty + Aleph source codes, adding a SETTINGS ACK flush resolved the problem and allowed all tests to pass. I may have been mislead by LLM about this, but hope we can get this sorted out 👍

@dergutemoritz Thanks for the info! I'll see if I can submit a patch when I have some time to spare 🙂

@robin.lahtinen Very nice, thanks a lot! I'll get to it asap - I'm currently a bit limited due to flu season 🤧

All is well. Take care :)

No rush, health comes first 😄

The plan / intention exists, yes: https://github.com/clj-commons/aleph/issues/760

It probably isn't too difficult to pull off. Just nobody got around to it, yet.

Patches very welcome 🙂

And no need to apologize! 🙂

All good, we don't have a policy on this, yet 🙂 That change in particular just had that odd vibe of being very sure of itself without making sense to me nor https://github.com/netty/netty/issues/16142#issuecomment-4067796527. Then again, there's some evidence that it fixed the problem for you so maybe there's still merit in the patch even though the explanation doesn't make sense or so.

IIUIC you did run into this error consistently with JDK 21 in combination with the adaptive allocator?

Just pushed a branch with just that commit reverted and https://app.circleci.com/pipelines/github/clj-commons/aleph/859/workflows/88724f73-ae05-4f26-a759-cd62bc862743/jobs/1010 right away at least 😕

Was hoping for a more reliable reproducer 🙂

Sorry for the delay! I've been busy. I'm fine with you moving ahead with the Netty upgrade if you'd like. 🙏

No worries, I was / am also too busy over here 😅 I'll ping here if I beat you to it then!

And lemme know as well if you pick it up again so that we don't waste our time in parallel