Clojurians Log v2

Great, thank you! Will get back to it today

Thanks! Can you resolve your comments and approve the respective PRs for posterity? 🙏 Not sure if you need extra permission for the latter though

Indeed, it's big and also quite subtle. I hope the PR description helps 🙏

I can't resolve comments but approved

Thanks a lot for your feedback so far! Already responded to some of it but gotta run now. Will get back to the remaining one tomorrow! 🙏

looks good!

Got interrupted by a cold 😬 Back to you 🙂 🙏

Thanks a lot for your feedback once more! Back to you 🙂

Other than what I commented on it lgtm 🚀

Great, thanks 🙂 Do you also feel up to reviewing the follow-up patches?

Or did you already?

I didn't see those. I'll take a look tomorrow

That's great, thank you!

They're linked from the main one

Thanks a lot! Now there's only one remaining which indeed makes the tests pass again 🙂 It's https://github.com/clj-commons/manifold/pull/252. I asked the original author of the code in question to review it but you're still welcome to check it out, as well, of course 🙂

that's a big one huh. i'll see if i can find some time tomorrow to look at it