Clojurians Log v2
Clojure programming
Channels
Apps
aleph
valerauko 2024-12-05T01:19:15.448229Z
Is aleph.http.multipart production ready at this point? I recall there were... issues with it a few years back
Arnaud Geiser 2024-12-06T08:08:43.687589Z
Understoood! The truth is; we introduced the fix after your bug report, so I'm expecting you to be the first one to use that feature. Please report if it works the way you want (or not).
🙏 1
Matthew Davidson 2024-12-06T03:32:50.312319Z
I believe @arnaudgeiser is the person to ask
Arnaud Geiser 2024-12-06T07:56:31.489979Z
Hello @vale,
While we are using Aleph extensively, we are not using the aleph.http.multipart feature.
We had issues back then with the cleanup of parts that ended up being files on the filesystem.
You will find information related to the current situation here : https://cljdoc.org/d/aleph/aleph/0.8.1/doc/http/handling-multipart-requests
TL;DR:
• Ensuring that all multipart requests will end up on memory will work without issues
• Using files on FS will require you to use the "Manual cleanup"
valerauko 2024-12-06T07:59:20.960459Z
gotcha. personally i consider "manual cleanup" a small price to pay to get rid of the whole apache-commons dependency that ring pulls in just to parse multipart