Clojurians Log v2

Created an MRE: https://github.com/p-himik/aleph-bytebuf-conversion-issue-test

Seems like the difference has appeared in 0.5.0-rc1.

Oh, crap... byte-streams is now split in two. Well that's a bloody nightmare. If I have any library that requires byte-streams, it will not be compatible with the new version of Aleph.

Commented here: https://github.com/clj-commons/byte-streams/issues/63#issuecomment-1362080491

See https://github.com/clj-commons/byte-streams/pull/66

Thanks! Will try a bit later today.

Yeah, reading between the lines of https://gist.github.com/malcolmsparks/bcfdcd9ae51e69aa3018c04d48f8749b it seems like there is something on the horizon 🤔

esp. > I have since arrived at the opinion that what yada attempts is too ambitious.

Hello, sorry for the blast from the past... I googled the following and brought me here

java.lang.IllegalArgumentException: Don't know how to convert class io.netty.buffer.PooledSlicedByteBuf into class [B
                                                                                                                    at byte_streams$convert.invokeStatic (byte_streams.clj:196)
                                                                                                                    byte_streams$convert.invoke (byte_streams.clj:162)
                                                                                                                    byte_streams.graph$seq_conversion_fn$fn__27758$fn__27765.invoke (graph.clj:314)
                                                                                                                    clojure.core$map$fn__5884.invoke (core.clj:2759)
                                                                                                                    clojure.lang.LazySeq.sval (LazySeq.java:42)
                                                                                                                    clojure.lang.LazySeq.seq (LazySeq.java:51)
                                                                                                                    clojure.lang.RT.seq (RT.java:535)
                                                                                                                    clojure.core$seq__5419.invokeStatic (core.clj:139)
                                                                                                                    clojure.core$map$fn__5884.invoke (core.clj:2750)
                                                                                                                    clojure.lang.LazySeq.sval (LazySeq.java:42)
                                                                                                                    clojure.lang.LazySeq.seq (LazySeq.java:51)
                                                                                                                    clojure.lang.RT.seq (RT.java:535)
                                                                                                                    clojure.core$seq__5419.invokeStatic (core.clj:139)
                                                                                                                    clojure.core$empty_QMARK_.invokeStatic (core.clj:6195)
                                                                                                                    clojure.core$empty_QMARK_.invoke (core.clj:6195)
                                                                                                                    manifold.stream.seq.SeqSource.take (seq.clj:42)
                                                                                                                    manifold.stream.graph$sync_connect$f__2887__auto____4902.invoke (graph.clj:272)
                                                                                                                    clojure.lang.AFn.run (AFn.java:22)
                                                                                                                    io.aleph.dirigiste.Executor$3.run (Executor.java:320)
                                                                                                                    io.aleph.dirigiste.Executor$Worker$1.run (Executor.java:62)
                                                                                                                    manifold.executor$thread_factory$reify__2329$f__2330.invoke (executor.clj:70)
                                                                                                                    clojure.lang.AFn.run (AFn.java:22)
                                                                                                                    java.lang.Thread.run (Thread.java:833)

[yada "1.2.15"]

                 ;; 
                 [aleph "0.6.2"]
                 [org.clj-commons/byte-streams "0.3.2"]
                 [manifold "0.4.1"]

I downgraded the dependencies like this and the problem is gone (i.e. request body id properly consumed)

;; 
                 [aleph "0.4.7-alpha5"]#_[aleph "0.6.2"]
                 #_[org.clj-commons/byte-streams "0.3.2"]
                 [manifold "0.1.9-alpha3"]#_[manifold "0.4.1"]

Hmmm.

byte-streams is synced with the latest Aleph, but I've been busy with adding HTTP/2 and haven't made sure the latest manifold is synced up

@iku000888 BTW, do you have a minimal example I could look at, with yada in the mix?

Also, does moving yada after aleph/bs/manifold fix the issues?

Thanks @kingmob! I did eventually figured out that yada's byte-streams was being picked up and excluding it from yada resolved the issue! https://clojurians.slack.com/archives/C0G922PCH/p1685706615663399 The project is not minimal so this is the best I can share at the moment 🙏

Glad it worked out

Unfortunately, it doesn't look like anyone's updated yada in 3 years, or I'd submit a PR