Fork me on GitHub
#aleph
<
2019-08-29
>
mccraigmccraig10:08:26

i don't know about assembling the JSON fragments @thomas559 , but be aware the manifold.stream/stream->seq may cause blocking - if your app is non-blocking then you will probably want to use a combination of manifold.stream/map and manifold.stream/reduce instead

thomas55918:08:44

@mccraigmccraig - does it become blocking any time the stream is converted to a lazy seq, or is that specific to the stream->seq function? I was exploring either using lazy-seq to assemble the pieces, or else manifold.stream/transform.

mccraigmccraig18:08:45

@thomas559 it's because stream->seq does a deref internally, and deref is blocking - https://github.com/ztellman/manifold/blob/master/src/manifold/stream.clj#L552

mccraigmccraig18:08:45

using manifold.stream/transform should be fine

thomas55918:08:00

Ah, got it. Thanks!